spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1508][SQL] Add SQLConf to SQLContext.
Date Fri, 06 Jun 2014 07:20:35 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/956#discussion_r13478757
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
---
    @@ -177,8 +177,7 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan]
{
     
       // Can we automate these 'pass through' operations?
       object BasicOperators extends Strategy {
    -    // TODO: Set
    -    val numPartitions = 200
    +    def numPartitions = sqlConf.get("spark.sql.shufflePartitions", "200").toInt
    --- End diff --
    
    Also need to fix [here](https://github.com/concretevitamin/spark/blob/sqlconf/sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala?pr=%2Fapache%2Fspark%2Fpull%2F956#L91).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message