Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: tmyklebu <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-593-spark@git.apache.org>
In-Reply-To: <git-pr-593-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-1672][WIP] Separate partitioning
 in ALS
Content-Type: text/plain
Message-Id: <20140501165633.B9A6588BA26@tyr.zones.apache.org>
Date: Thu,  1 May 2014 16:56:33 +0000 (UTC)

Github user tmyklebu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/593#discussion_r12195324
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -381,14 +399,15 @@ class ALS private (
        * the users (or (blockId, (p, u, r)) for the products). We create these simultaneously to avoid
        * having to shuffle the (blockId, (u, p, r)) RDD twice, or to cache it.
        */
    -  private def makeLinkRDDs(numBlocks: Int, ratings: RDD[(Int, Rating)], partitioner: Partitioner)
    +  private def makeLinkRDDs(numUserBlocks: Int, numProductBlocks: Int, ratings: RDD[(Int, Rating)],
    +    userPartitioner: Partitioner, productPartitioner: Partitioner)
    --- End diff --
    
    Nope!  Nice catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---