spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1914] [SQL] Simplify CountFunction not ...
Date Fri, 23 May 2014 10:43:45 GMT
GitHub user ueshin opened a pull request:

    https://github.com/apache/spark/pull/861

    [SPARK-1914] [SQL] Simplify CountFunction not to traverse to evaluate all child expressions.

    `CountFunction` should count up only if the child's evaluated value is not null.
    
    Because it traverses to evaluate all child expressions, even if the child is null, it
counts up if one of the all children is not null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ueshin/apache-spark issues/SPARK-1914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #861
    
----
commit 2afa2386b0f59d1d50f11de2d444f191335867ef
Author: Takuya UESHIN <ueshin@happy-camper.st>
Date:   2014-05-23T10:15:44Z

    Simplify CountFunction not to traverse to evaluate all child expressions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message