spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Owen <so...@cloudera.com>
Subject Re: [GitHub] spark pull request: Fix SPARK-1629: Spark should inline use of com...
Date Sun, 04 May 2014 23:16:25 GMT
Agree, this has not changed since java 1.1 or so. The niggling remaining
issue is that a test does use it too so technically needs the dependency
tweak anyway. And tachyon already brings it in.

That use can't be inlined but pretty certain is just a string replace. I
don't know if tachyon's use is likewise trivial.
 On May 5, 2014 12:12 AM, "pwendell" <git@git.apache.org> wrote:

> Github user pwendell commented on the pull request:
>
>     https://github.com/apache/spark/pull/569#issuecomment-42150290
>
>     I'm ambivalent between inlining this and fixing up the dependency. In
> general we should probably rely on other utilities where possible, but if
> the JVM ever changes the way windows machines identify themselves in a
> non-backwards-compatible fashion, I will eat my shoe.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message