spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1898: In deploy.yarn.Client, use YarnCli...
Date Thu, 22 May 2014 00:15:44 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/850#discussion_r12930178
  
    --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -132,15 +134,19 @@ class Client(clientArgs: ClientArguments, hadoopConf: Configuration,
spConf: Spa
       def submitApp(appContext: ApplicationSubmissionContext) = {
         // Submit the application to the applications manager.
         logInfo("Submitting application to ASM")
    -    super.submitApplication(appContext)
    +    yarnClient.submitApplication(appContext)
       }
     
    +  def getApplicationReport = yarnClient.getApplicationReport _
    +
    +  def stop = yarnClient.stop _
    --- End diff --
    
    Should `yarnClient.stop` be called directly just like other yarnClient methods?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message