spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1877: ClassNotFoundException when loadin...
Date Tue, 20 May 2014 02:50:37 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/821#discussion_r12826101
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -718,7 +718,7 @@ class SparkContext(config: SparkConf) extends Logging {
           minPartitions: Int = defaultMinPartitions
           ): RDD[T] = {
         sequenceFile(path, classOf[NullWritable], classOf[BytesWritable], minPartitions)
    -      .flatMap(x => Utils.deserialize[Array[T]](x._2.getBytes))
    +      .flatMap(x => Utils.deserialize[Array[T]](x._2.getBytes, Thread.currentThread.getContextClassLoader))
    --- End diff --
    
    Could you change this to `Utils.getContextOrSparkClassLoader`? It's not always the case
that the context classloader is set, and the utility function deals with that correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message