spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1876] Windows fixes to deal with latest...
Date Mon, 19 May 2014 04:05:33 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/819#discussion_r12778839
  
    --- Diff: bin/run-example2.cmd ---
    @@ -30,7 +30,9 @@ if exist "%FWDIR%conf\spark-env.cmd" call "%FWDIR%conf\spark-env.cmd"
     
     rem Test that an argument was given
     if not "x%1"=="x" goto arg_given
    -  echo Usage: run-example ^<example-class^> [^<args^>]
    +  echo Usage: run-example ^<example-class^> [^<example-args^>]
    --- End diff --
    
    small nit: it's not clear what `[<args>]` means. How about just `[example-args]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message