spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <>
Subject [GitHub] spark pull request: [SPARK-1769] Executor loss causes NPE race con...
Date Wed, 14 May 2014 05:10:55 GMT
Github user aarondav commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
    @@ -35,18 +37,15 @@ private[spark] class Pool(
       extends Schedulable
       with Logging {
    -  var schedulableQueue = new ArrayBuffer[Schedulable]
    -  var schedulableNameToSchedulable = new HashMap[String, Schedulable]
    +  val schedulableQueue = new LinkedBlockingQueue[Schedulable]
    --- End diff --
    nit: ConurrentLinkedQueue is a more suitable data structure for this type of access --
it provides a very efficient linked list, and it uses "add()" instead of "offer()". Also no
blocking stuff.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message