spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mridulm <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1706: Allow multiple executors per worke...
Date Sun, 11 May 2014 23:50:50 GMT
Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/731#discussion_r12511580
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -532,6 +516,99 @@ private[spark] class Master(
         }
       }
     
    +  private def startMultiExecutorsPerWorker() {
    +    // allow user to run multiple executors in the same worker
    +    // (within the same worker JVM process)
    +    if (spreadOutApps) {
    +      for (app <- waitingApps if app.coresLeft > 0) {
    +        val memoryPerExecutor = app.desc.memoryPerExecutor
    +        var usableWorkers = workers.toArray.filter(_.state == WorkerState.ALIVE).
    +          filter(worker => worker.coresFree > 0 && worker.memoryFree >=
memoryPerExecutor).
    +          sortBy(_.memoryFree / memoryPerExecutor).reverse
    +        val maxCoreNumPerExecutor = app.desc.maxCorePerExecutor.get
    +        // get the maximum total number of executors we can assign
    +        var maxLeftExecutorsToAssign = usableWorkers.map(_.memoryFree / memoryPerExecutor).sum
    +        var maxCoresLeft = maxLeftExecutorsToAssign * maxCoreNumPerExecutor
    --- End diff --
    
    I am not sure what maxCoresLeft is supposed to signify.
    maxLeftExecutorsToAssign seems to be assigned to number of memory slots available
    Which seems orthogonal to maxCoreNumPerExecutor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message