spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1579: Clean up PythonRDD and avoid swall...
Date Wed, 07 May 2014 01:31:15 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/640#discussion_r12358598
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala ---
    @@ -17,11 +17,13 @@
     
     package org.apache.spark.scheduler
     
    +import scala.language.existentials
    +
     import java.io._
     import java.util.zip.{GZIPInputStream, GZIPOutputStream}
     
     import scala.collection.mutable.HashMap
    -import scala.language.existentials
    +import scala.util.Try
    --- End diff --
    
    Mm, it was decided (on the dev list) that we'd put Scala language features above all other
imports. I guess that hasn't made its way to the code style guide yet...
    
    Removed the Try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message