spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1460] Returning SchemaRDD instead of no...
Date Mon, 05 May 2014 22:35:36 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/448#discussion_r12303586
  
    --- Diff: graphx/src/main/scala/org/apache/spark/graphx/VertexRDD.scala ---
    @@ -71,18 +71,18 @@ class VertexRDD[@specialized VD: ClassTag](
       override protected def getPreferredLocations(s: Partition): Seq[String] =
         partitionsRDD.preferredLocations(s)
     
    -  override def persist(newLevel: StorageLevel): VertexRDD[VD] = {
    +  override def persist(newLevel: StorageLevel): this.type = {
    --- End diff --
    
    @rxin can we just remove these functions if RDD returns this.type instead?  It looks like
you were only overloading them for the covariant return type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message