spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: get sparkhome from sparkconf Preferentially
Date Fri, 02 May 2014 03:52:30 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/615#discussion_r12218870
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ---
    @@ -83,7 +83,8 @@ private[spark] class Worker(
       @volatile var registered = false
       @volatile var connected = false
       val workerId = generateWorkerId()
    -  val sparkHome = new File(Option(System.getenv("SPARK_HOME")).getOrElse("."))
    +  val sparkHome = new File(conf.getOption("spark.home").orElse(Option(
    --- End diff --
    
    Just wondering, could you describe the use case where you want to set this via a Spark
property and not by setting `SPARK_HOME` on the cluster?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message