Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: shivaram <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-134-spark@git.apache.org>
In-Reply-To: <git-pr-134-spark@git.apache.org>
Subject: [GitHub] spark pull request: Add unit test to spark_ec2 script
Content-Type: text/plain
Message-Id: <20140424175439.E53F99916D6@tyr.zones.apache.org>
Date: Thu, 24 Apr 2014 17:54:39 +0000 (UTC)

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/134#discussion_r11961673
  
    --- Diff: ec2/tests.py ---
    @@ -0,0 +1,25 @@
    +import unittest
    +
    +from boto import ec2
    +import mock
    +import moto
    +
    +import spark_ec2
    +
    --- End diff --
    
    Actually I check code in pyspark as well and we do follow the flake8 defaults of extra newline before classes. So keep this in is absolutely fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---