Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: marmbrus <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-511-spark@git.apache.org>
In-Reply-To: <git-pr-511-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-1487 [SQL] Support record
 filtering via ...
Content-Type: text/plain
Message-Id: <20140423235551.3DDE298FCC1@tyr.zones.apache.org>
Date: Wed, 23 Apr 2014 23:55:51 +0000 (UTC)

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/511#discussion_r11930769
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala ---
    @@ -27,15 +27,17 @@ import org.apache.hadoop.mapreduce._
     import org.apache.hadoop.mapreduce.lib.input.{FileInputFormat => NewFileInputFormat}
     import org.apache.hadoop.mapreduce.lib.output.{FileOutputFormat => NewFileOutputFormat, FileOutputCommitter}
     
    -import parquet.hadoop.{ParquetInputFormat, ParquetOutputFormat}
    +import parquet.hadoop.{ParquetRecordReader, BadConfigurationException, ParquetInputFormat, ParquetOutputFormat}
     import parquet.hadoop.util.ContextUtil
     import parquet.io.InvalidRecordException
     import parquet.schema.MessageType
     
    -import org.apache.spark.{SerializableWritable, SparkContext, TaskContext}
    +import org.apache.spark.{Logging, SerializableWritable, SparkContext, TaskContext}
     import org.apache.spark.rdd.RDD
    -import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression, Row}
    +import org.apache.spark.sql.catalyst.expressions.{BinaryComparison, Attribute, Expression, Row}
     import org.apache.spark.sql.execution.{LeafNode, SparkPlan, UnaryNode}
    +import parquet.filter.UnboundRecordFilter
    --- End diff --
    
    put these up with the other parquet things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---