Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: andrewor14 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-421-spark@git.apache.org>
In-Reply-To: <git-pr-421-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-1399: show stage failure reason in
 UI
Content-Type: text/plain
Message-Id: <20140421211015.438B698ECB3@tyr.zones.apache.org>
Date: Mon, 21 Apr 2014 21:10:15 +0000 (UTC)

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/421#discussion_r11826460
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
    @@ -27,34 +27,37 @@ import org.apache.spark.ui.UIUtils
     import org.apache.spark.util.Utils
     
     /** Page showing list of all ongoing and recently finished stages */
    -private[ui] class StageTable(
    +private[ui] class StageTableBase(
         stages: Seq[StageInfo],
         parent: JobProgressTab,
         killEnabled: Boolean = false) {
     
       private val basePath = parent.basePath
       private val listener = parent.listener
    -  private lazy val isFairScheduler = parent.isFairScheduler
    +  protected def isFairScheduler = parent.isFairScheduler
    +
    +  protected def columns: Seq[Node] = {
    +    // create dummy element to wrap the columns
    --- End diff --
    
    except this comment is no longer true, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---