Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: tdas <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-126-spark@git.apache.org>
In-Reply-To: <git-pr-126-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-1103] [WIP] Automatic garbage
 collectio...
Content-Type: text/plain
Message-Id: <20140408023919.CC84C94D723@tyr.zones.apache.org>
Date: Tue,  8 Apr 2014 02:39:19 +0000 (UTC)

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/126#discussion_r11374621
  
    --- Diff: core/src/main/scala/org/apache/spark/broadcast/HttpBroadcast.scala ---
    @@ -54,7 +85,15 @@ private[spark] class HttpBroadcast[T](@transient var value_ : T, isLocal: Boolea
               logInfo("Started reading broadcast variable " + id)
               val start = System.nanoTime
               value_ = HttpBroadcast.read[T](id)
    -          SparkEnv.get.blockManager.putSingle(blockId, value_, StorageLevel.MEMORY_AND_DISK, false)
    +          /*
    +           * Storing the broadcast data in BlockManager so that all
    --- End diff --
    
    Fixed. Will push with all updates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---