spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From advancedxy <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1511] use Files.move instead of renameT...
Date Wed, 16 Apr 2014 13:49:47 GMT
GitHub user advancedxy opened a pull request:

    https://github.com/apache/spark/pull/427

    [SPARK-1511] use Files.move instead of renameTo in TestUtils.scala

    JIRA issue:[SPARK-1511](https://issues.apache.org/jira/browse/SPARK-1511)
    
    TestUtils.createCompiledClass method use renameTo() to move files which fails when the
src and dest files are in different disks or partitions. This pr uses Files.move() instead.
The move method will try to use renameTo() and then fall back to copy() and delete(). I think
this should handle this issue.
    
    I didn't found a test suite for this file, so I add file existence detection after file
moving.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/advancedxy/spark SPARK-1511

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #427
    
----
commit 6f95550ddca26ede94fd419f2fa30ecb4339162c
Author: Ye Xianjin <advancedxy@gmail.com>
Date:   2014-04-16T13:35:58Z

    use Files.move instead of renameTo to handle the src and dest files are
    in different disks or partitions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message