spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...
Date Thu, 24 Apr 2014 19:38:18 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/186#discussion_r11967807
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -322,6 +289,14 @@ class DAGScheduler(
         missing.toList
       }
     
    +  private def startDAGSchedulerActors() {
    +    dagSchedulerActorSupervisor = env.actorSystem.actorOf(Props(
    +      new DAGSchedulerActorSupervisor(this)))
    +    while (dagSchedulerActorSupervisor == null || eventProcessActor == null) {
    --- End diff --
    
    Hi, @pwendell , this was added last night, 
    
    as I explained, now, actorOf is non-blocking, I found it because sometimes DAGScheduler.submitJob()
is called before eventProcessActor is well initialized causing NPE in https://github.com/CodingCat/spark/blob/SPARK-1235/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L428,
though we are building eventProcessActor in the constructor of DAGScheduler....
    
    I agree that ....ah...busy waiting here need to be fixed
    
    for why we set a global status in supervisorActor....I think it's just to minimize the
modification.....I can move declaration of eventProcessActor to supervisor....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message