spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: Spark 1490 Add kerberos support to the History...
Date Thu, 24 Apr 2014 17:08:34 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/513#discussion_r11959433
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -266,6 +268,20 @@ object HistoryServer {
         while(true) { Thread.sleep(Int.MaxValue) }
         server.stop()
       }
    +
    +  def initSecurity() {
    +    // If we are accessing HDFS and it has security enabled (Kerberos), we have to login
    +    // from a keytab file so that we can access HDFS beyond the kerberos ticket expiration.
    +    // As long as it is using Hadoop rpc (hdfs://), a relogin will automatically
    +    // occur from the keytab.
    +    if (conf.getBoolean("spark.history.use.kerberos", false)) {
    --- End diff --
    
    could this be `spark.history.kerberos.enabled` to be more consistent with the other on/off
options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message