spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: Clean up and simplify Spark configuration
Date Fri, 18 Apr 2014 15:12:57 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/299#discussion_r11774661
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -122,6 +141,22 @@ private[spark] class SparkSubmitArguments(args: Array[String]) {
           driverCores = value
           parseOpts(tail)
     
    +    case ("--driver-class-path") :: value :: tail =>
    +      driverExtraClassPath = value
    +      parseOpts(tail)
    +
    +    case ("--driver-java-opts") :: value :: tail =>
    +      driverExtraJavaOptions = value
    +      parseOpts(tail)
    +
    +    case ("--driver-library-path") :: value :: tail =>
    +      driverExtraLibraryPath = value
    +      parseOpts(tail)
    +
    +    case ("--properties-file") :: value :: tail =>
    --- End diff --
    
    this isn't being printed in usage of spark-submit script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message