spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: ALS: Avoid the garbage-creating ctor of Double...
Date Fri, 18 Apr 2014 08:19:30 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/442#discussion_r11766593
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -303,6 +303,13 @@ class ALS private (
       }
     
       /**
    +   * Wrap a double array in a DoubleMatrix without creating garbage.
    +   */
    +  private def wrapDoubleArray(v: Array[Double]): DoubleMatrix = {
    +    new DoubleMatrix(v.length, 1, v:_*)
    --- End diff --
    
    put a space after `:`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message