spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1456 Remove view bounds on Ordered in fa...
Date Wed, 16 Apr 2014 16:28:55 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/410#discussion_r11692970
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
    @@ -27,12 +27,14 @@ import org.apache.spark.{Logging, RangePartitioner}
      * use these functions. They will work with any key type that has a `scala.math.Ordered`
      * implementation.
      */
    -class OrderedRDDFunctions[K <% Ordered[K]: ClassTag,
    +class OrderedRDDFunctions[K : Ordering : ClassTag,
    --- End diff --
    
    @marmbrus Do you mind updating the scaladoc above since now users can pass their own orderings
in addition to an `Ordered` type? It might be nice to just give a one-line example of how
they can define a custom ordering as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message