spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: Fix SPARK-1413: Parquet messes up stdout and s...
Date Thu, 10 Apr 2014 06:37:05 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/325#discussion_r11471909
  
    --- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
    @@ -135,4 +136,6 @@ trait Logging {
     private object Logging {
       @volatile private var initialized = false
       val initLock = new Object()
    +  SLF4JBridgeHandler.removeHandlersForRootLogger()
    --- End diff --
    
    @srowen the case I'm concerned about is the following. Someone wants to map SLF4J to JUL,
so they'd need to remove the "jul-to-slf4j" dependency otherwise they'll get a routing loop.
But then spark won't compile because this code depends on the `SLF4JBridgeHandler` which exists
only in the "jul-to-slf4j" jar. Am I missing something, or won't this cause a compile error
for a user in that situation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message