spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markhamstra <...@git.apache.org>
Subject [GitHub] spark pull request: remove scalalogging-slf4j dependency
Date Sun, 06 Apr 2014 18:52:33 GMT
Github user markhamstra commented on the pull request:

    https://github.com/apache/spark/pull/332#issuecomment-39676694
  
    Very similar to what I was thinking @marmbrus -- but you wrote it up more completely than
I would have.  This is also why I've been moving some performance-critical proprietary code
over to using Scala logging.  It isn't huge, but it does make a difference, and it's generally
no more difficult to use Scala logging than older methods, so I'd also like to see Spark moving
to use Typesafe's library. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message