spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kanzhang <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1348 binding Master, Worker, and App Web...
Date Sat, 05 Apr 2014 00:15:36 GMT
Github user kanzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/318#discussion_r11318636
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -177,7 +177,10 @@ private[spark] object JettyUtils extends Logging {
     
         @tailrec
         def connect(currentPort: Int): (Server, Int) = {
    -      val server = new Server(new InetSocketAddress(hostName, currentPort))
    +      val server = if ("0.0.0.0".equals(hostName))
    +          new Server(currentPort)
    +        else
    +          new Server(new InetSocketAddress(hostName, currentPort))
    --- End diff --
    
    Good catch. Just tested, 0.0.0.0 binds to all. will drop the change. 
    
    Hmm, I thought there was a reason previous impl chose to use val server = new Server(currentPort).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message