spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mridulm <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] Clean up and simplify Spark configuratio...
Date Thu, 03 Apr 2014 00:52:38 GMT
Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/299#discussion_r11235668
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -340,8 +341,22 @@ trait ClientBase extends Logging {
           JAVA_OPTS += " -XX:CMSIncrementalDutyCycle=10 "
         }
     
    -    if (env.isDefinedAt("SPARK_JAVA_OPTS")) {
    -      JAVA_OPTS += " " + env("SPARK_JAVA_OPTS")
    +
    --- End diff --
    
    Removing support for this is to going to fail too many jobs which are currently run via
cron, this is going to make things very messy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message