Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: markhamstra <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-186-spark@git.apache.org>
In-Reply-To: <git-pr-186-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-1235: kill the application when
 DAGSched...
Content-Type: text/plain
Message-Id: <20140331014328.CC9EF8874C5@tyr.zones.apache.org>
Date: Mon, 31 Mar 2014 01:43:28 +0000 (UTC)

Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/186#discussion_r11102108
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -150,7 +162,10 @@ class DAGScheduler(
               }
           }
         }))
    -  }
    +  }))
    +
    +  // set the dagscheduler until after the actor system is ready
    +  taskScheduler.setDAGScheduler(this)
    --- End diff --
    
    Well, you can't access it as `this` since `this` means something else within the eventProcessActor, but I think this should work:
    ```scala
    private[this] val thisDAGScheduler = this
    env.actorSystem.actorOf(Props(new Actor {  // the Supervisor
      ...
      eventProcessActor = context.actorOf(Props(new Actor {
        ...
        override def preStart() {
          taskScheduler.setDAGScheduler(thisDAGScheduler)
        }
    ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---