spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markhamstra <...@git.apache.org>
Subject [GitHub] spark pull request: DAGScheduler NullPointerException bug fix
Date Mon, 31 Mar 2014 04:35:42 GMT
Github user markhamstra commented on the pull request:

    https://github.com/apache/spark/pull/273#issuecomment-39053458
  
    @CodingCat there is the matter of the order of construction and starting of the taskScheduler
and the dagScheduler in SparkContext (https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L224.)
 I believe that https://github.com/apache/spark/pull/186 and the following should do things
in the right order:
    ```scala
      // Create and start the scheduler
      private[spark] var taskScheduler = SparkContext.createTaskScheduler(this, master)
      @volatile private[spark] var dagScheduler = new DAGScheduler(this)
      taskScheduler.start()
    
      postEnvironmentUpdate()
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message