spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1141] [WIP] Parallelize Task Serializat...
Date Mon, 31 Mar 2014 02:54:26 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/214#discussion_r11102844
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -149,6 +151,21 @@ private[spark] object Utils extends Logging {
         buf
       }
     
    +  def serializeTask(taskNoSer: TaskDescWithoutSerializedTask, sc: SparkContext,
    +                    serializer: SerializerInstance) : TaskDescription = {
    +    val startTime = System.currentTimeMillis()
    +    // We rely on the DAGScheduler to catch non-serializable closures and RDDs, so in
here
    --- End diff --
    
    is it difficult to capture the non-serializable objects here? as @kayousterhout said in
one of my PRs, DAGScheduler knows too much about task-level details now...maybe we can do
something to make the situation better.....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message