spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AndreSchumacher <...@git.apache.org>
Subject [GitHub] spark pull request: Spark parquet improvements
Date Fri, 28 Mar 2014 15:39:27 GMT
Github user AndreSchumacher commented on a diff in the pull request:

    https://github.com/apache/spark/pull/195#discussion_r11071279
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
---
    @@ -40,7 +40,7 @@ import java.util.Date
      * Parquet table scan operator. Imports the file that backs the given
      * [[ParquetRelation]] as a RDD[Row].
      */
    -case class ParquetTableScan(
    +private[sql] case class ParquetTableScan(
         @transient output: Seq[Attribute],
         @transient relation: ParquetRelation,
         @transient columnPruningPred: Option[Expression])(
    --- End diff --
    
    @jerryshao I can't comment on the ``SparkEquiInnerJoin`` code but I was also under the
impression these fields would only be used to build the execution plan. I'm fine with removing
the transient if needed though (@rxin suggested to make these transient, any comments?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message