spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1212] Adding sparse data support and up...
Date Fri, 21 Mar 2014 21:16:47 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/117#discussion_r10854995
  
    --- Diff: NOTICE ---
    @@ -3,3 +3,12 @@ Copyright 2013 The Apache Software Foundation.
     
     This product includes software developed at
     The Apache Software Foundation (http://www.apache.org/).
    +
    +Numerical linear algebra support in MLlib is provided by the breeze package, 
    +which depends on the following package that are not distributed under 
    +an Apache authorized license:
    +
    +- JTransforms, which is open source software written by Piotr Wendykier, 
    +  and distributed under the the terms of the MPL/LGPL/GPL tri-license. 
    +  The original software is available from
    +    https://sites.google.com/site/piotrwendykier/software/jtransforms
    --- End diff --
    
    @mateiz I don't quite understand what your concern is. What is the downside if we put
it in NOTICE instead of LICENSE? The JIRA I mentioned was answered by two Apache members,
so I think that is the "official" instruction for "appropriate labeling".
    
    Detaching it from Breeze might not be a good idea, as both breeze and mllib might need
JTransforms in the future. Fast transforms are used extensively in dimension reduction and
signal processing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message