spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1286: Make usage of spark-env.sh idempot...
Date Thu, 20 Mar 2014 05:20:35 GMT
Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/184#discussion_r10783017
  
    --- Diff: bin/load-spark-env ---
    @@ -0,0 +1,35 @@
    +#!/usr/bin/env bash
    --- End diff --
    
    To be consistent with other scripts, can we call this `load-spark-env.sh`? The ones without
`.sh` are the ones we want users to call directly, but this isn't one of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message