spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1278: Fix improper use of SimpleDateForm...
Date Wed, 19 Mar 2014 17:50:20 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/179#discussion_r10761749
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -32,7 +33,7 @@ import org.apache.spark.util.{Utils, Distribution}
     /** Page showing statistics and task list for a given stage */
     private[spark] class StagePage(parent: JobProgressUI) {
       def listener = parent.listener
    -  val dateFmt = parent.dateFmt
    +  def dateFmt(): DateFormat = parent.dateFmt
    --- End diff --
    
    ```
    val dateFmt = WebUI.createDateFormat
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message