spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: Principal Component Analysis
Date Tue, 18 Mar 2014 20:22:22 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/88#discussion_r10723633
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/SVD.scala ---
    @@ -38,12 +39,27 @@ class SVD {
         this
       }
     
    -   /**
    -   * Compute SVD using the current set parameters
    +  /**
    +   * Should U be computed?
        */
    +  def setComputeU(compU: Boolean): SVD = {
    +    this.computeU = compU
    +    this
    +  }
    +
    +  /**
    +  * Compute SVD using the current set parameters
    --- End diff --
    
    Should have 3 spaces before `*`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message