spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1266] persist factors in implicit ALS
Date Tue, 18 Mar 2014 07:08:23 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/165#discussion_r10692598
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -445,7 +476,7 @@ class ALS private (
           // Solve the resulting matrix, which is symmetric and positive-definite
           implicitPrefs match {
    --- End diff --
    
    This is a minor style thing but I originally had used a `match` statement all around,
and I did change most of them to `if (implicitPrefs) ... else ...`. I seem to have missed
this one, perhaps you can make that change while you're at it? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message