spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1186] : Enrich the Spark Shell to suppo...
Date Mon, 17 Mar 2014 19:38:40 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/116#discussion_r10674709
  
    --- Diff: bin/spark-shell ---
    @@ -30,69 +30,378 @@ esac
     # Enter posix mode for bash
     set -o posix
     
    -CORE_PATTERN="^[0-9]+$"
    -MEM_PATTERN="^[0-9]+[m|g|M|G]$"
    -
    +## Global script variables
     FWDIR="$(cd `dirname $0`/..; pwd)"
     
    -if [ "$1" = "--help" ] || [ "$1" = "-h" ]; then
    -	echo "Usage: spark-shell [OPTIONS]"
    -	echo "OPTIONS:"
    -	echo "-c --cores num, the maximum number of cores to be used by the spark shell"
    -	echo "-em --execmem num[m|g], the memory used by each executor of spark shell"
    -	echo "-dm --drivermem num[m|g], the memory used by the spark shell and driver"
    -	echo "-h --help, print this help information" 
    -	exit
    -fi
    +VERBOSE=0
    +DRY_RUN=0
    +SPARK_REPL_OPTS="${SPARK_REPL_OPTS:-""}"
    --- End diff --
    
    Is there a distinction between `${SPARK_REPL_OPTS:-""}` and just `$SPARK_REPl_OPTS`? I'm
just not certain what this is trying to accomplish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message