spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-31842) DAGSchedulerSuite: For the pattern of runevent + assert, extract the general method
Date Mon, 06 Jul 2020 03:14:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-31842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151731#comment-17151731
] 

Apache Spark commented on SPARK-31842:
--------------------------------------

User 'warrenzhu25' has created a pull request for this issue:
https://github.com/apache/spark/pull/29005

> DAGSchedulerSuite: For the pattern of runevent + assert, extract the general method
> -----------------------------------------------------------------------------------
>
>                 Key: SPARK-31842
>                 URL: https://issues.apache.org/jira/browse/SPARK-31842
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Spark Core
>    Affects Versions: 3.1.0
>            Reporter: jiaan.geng
>            Priority: Major
>
> DAGSchedulerSuite exists many test case(e.g. late fetch failures / task events always
posted / ignore late map task completions) contains the pattern of runevent + assert, such
as:
> {code:java}
>     runEvent(makeCompletionEvent(
>       taskSets(1).tasks(0),
>       FetchFailed(makeBlockManagerId("hostA"), shuffleId, 0L, 0, 0, "ignored"),
>       null))
>     assert(sparkListener.failedStages.contains(1))
> {code}
> We should extract the general method like runEventAndCheck(events*, predicate)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message