spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyukjin Kwon (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-20485) Split ALS.scala into multiple files
Date Tue, 21 May 2019 04:12:34 GMT

     [ https://issues.apache.org/jira/browse/SPARK-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hyukjin Kwon resolved SPARK-20485.
----------------------------------
    Resolution: Incomplete

> Split ALS.scala into multiple files
> -----------------------------------
>
>                 Key: SPARK-20485
>                 URL: https://issues.apache.org/jira/browse/SPARK-20485
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML, MLlib
>    Affects Versions: 2.1.0
>            Reporter: Daniel Li
>            Priority: Trivial
>              Labels: bulk-closed
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The file {{/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala}} currently
contains four top-level classes that span 1,500+ lines.  To make the file easier to navigate,
and to bring it in line with the [Scala style guide|http://docs.scala-lang.org/style/files.html],
I propose we split it into four files holding their respective classes: {{ALS.scala}}, {{ALSParams.scala}},
{{ALSModel.scala}}, and {{ALSModelParams.scala}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message