spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-26327) Metrics in FileSourceScanExec not update correctly while relation.partitionSchema is set
Date Tue, 11 Dec 2018 13:27:03 GMT

    [ https://issues.apache.org/jira/browse/SPARK-26327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717132#comment-16717132
] 

ASF GitHub Bot commented on SPARK-26327:
----------------------------------------

xuanyuanking opened a new pull request #23287: [SPARK-26327][SQL][BACKPORT-2.4] Bug fix for
`FileSourceScanExec` metrics update
URL: https://github.com/apache/spark/pull/23287
 
 
   ## What changes were proposed in this pull request?
   
   Backport #23277 to branch 2.4 without the metrics renaming.
   
   ## How was this patch tested?
   
   New test case in `SQLMetricsSuite`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Metrics in FileSourceScanExec not update correctly while relation.partitionSchema is
set
> ----------------------------------------------------------------------------------------
>
>                 Key: SPARK-26327
>                 URL: https://issues.apache.org/jira/browse/SPARK-26327
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Yuanjian Li
>            Assignee: Yuanjian Li
>            Priority: Major
>             Fix For: 3.0.0
>
>
> As currently approach in `FileSourceScanExec`, the metrics of "numFiles" and "metadataTime"(fileListingTime)
were updated while lazy val `selectedPartitions` initialized in the scenario of relation.partitionSchema
is set. But `selectedPartitions` will be initialized by `metadata` at first, which is called
by `queryExecution.toString` in `SQLExecution.withNewExecutionId`. So while the `SQLMetrics.postDriverMetricUpdates`
called, there's no corresponding liveExecutions in SQLAppStatusListener, the metrics update
is not work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message