spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takeshi Yamamuro (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-26215) define reserved keywords after SQL standard
Date Mon, 03 Dec 2018 12:10:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-26215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707095#comment-16707095
] 

Takeshi Yamamuro commented on SPARK-26215:
------------------------------------------

These reserved words should be handled inside SqlBase.g4? It seems postgresql do so https://github.com/postgres/postgres/blob/ee2b37ae044f34851baba69e9ba737077326414e/src/backend/parser/gram.y#L15366

> define reserved keywords after SQL standard
> -------------------------------------------
>
>                 Key: SPARK-26215
>                 URL: https://issues.apache.org/jira/browse/SPARK-26215
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Wenchen Fan
>            Priority: Major
>
> There are 2 kinds of SQL keywords: reserved and non-reserved. Reserved keywords can't
be used as identifiers.
> In Spark SQL, we are too tolerant about non-reserved keywors. A lot of keywords are non-reserved
and sometimes it cause ambiguity (IIRC we hit a problem when improving the INTERVAL syntax).
> I think it will be better to just follow other databases or SQL standard to define reserved
keywords, so that we don't need to think very hard about how to avoid ambiguity.
> For reference: https://www.postgresql.org/docs/8.1/sql-keywords-appendix.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message