spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiangrui Meng (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SPARK-25321) ML, Graph 2.4 QA: API: New Scala APIs, docs
Date Tue, 18 Sep 2018 05:22:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-25321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618495#comment-16618495
] 

Xiangrui Meng edited comment on SPARK-25321 at 9/18/18 5:21 AM:
----------------------------------------------------------------

[~WeichenXu123] Could you check whether mleap is compatible with the tree Node breaking changes?
This line is relevant: https://github.com/combust/mleap/blob/master/mleap-runtime/src/main/scala/ml/combust/mleap/bundle/ops/classification/DecisionTreeClassifierOp.scala

If it is hard to make MLeap upgrade, we should revert the change in 2.4.

cc: [~hollinwilkins]


was (Author: mengxr):
[~WeichenXu123] Could you check whether mleap is compatible with the tree Node breaking changes?
This line is relevant: https://github.com/combust/mleap/blob/master/mleap-runtime/src/main/scala/ml/combust/mleap/bundle/ops/classification/DecisionTreeClassifierOp.scala

If it is hard to make MLeap upgrade, we should revert the change.

cc: [~hollinwilkins]

> ML, Graph 2.4 QA: API: New Scala APIs, docs
> -------------------------------------------
>
>                 Key: SPARK-25321
>                 URL: https://issues.apache.org/jira/browse/SPARK-25321
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Documentation, GraphX, ML, MLlib
>    Affects Versions: 2.4.0
>            Reporter: Weichen Xu
>            Assignee: Yanbo Liang
>            Priority: Blocker
>
> Audit new public Scala APIs added to MLlib & GraphX. Take note of:
>  * Protected/public classes or methods. If access can be more private, then it should
be.
>  * Also look for non-sealed traits.
>  * Documentation: Missing? Bad links or formatting?
> *Make sure to check the object doc!*
> As you find issues, please create JIRAs and link them to this issue. 
> For *user guide issues* link the new JIRAs to the relevant user guide QA issue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message