From issues-return-198204-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Aug 7 02:00:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 170C8180676 for ; Tue, 7 Aug 2018 02:00:04 +0200 (CEST) Received: (qmail 17929 invoked by uid 500); 7 Aug 2018 00:00:04 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 17920 invoked by uid 99); 7 Aug 2018 00:00:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 00:00:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CE995C0370 for ; Tue, 7 Aug 2018 00:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jpbT5diLjUg2 for ; Tue, 7 Aug 2018 00:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B8B065F357 for ; Tue, 7 Aug 2018 00:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E95B3E0E3E for ; Tue, 7 Aug 2018 00:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AA25C23F9D for ; Tue, 7 Aug 2018 00:00:00 +0000 (UTC) Date: Tue, 7 Aug 2018 00:00:00 +0000 (UTC) From: "Chris O'Hara (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SPARK-25037) plan.transformAllExpressions() doesn't transform expressions in nested SubqueryExpression plans MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-25037?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris O'Hara updated SPARK-25037: --------------------------------- Description:=20 Given the following LogicalPlan: {code:java} scala> val plan =3D spark.sql("SELECT 1 bar FROM (SELECT 1 foo) WHERE foo I= N (SELECT 1 foo)").queryExecution.logical plan: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan =3D 'Project [1 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [1 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} the following transformation should replace all instances of lit(1) with li= t(2): {code:java} scala> plan.transformAllExpressions { case l @ Literal(1, _) =3D> l.copy(va= lue =3D 2) } res0: plan.type =3D 'Project [2 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} Instead, the nested SubqueryExpression plan is not transformed. The expected output is:=C2=A0 {code:java} 'Project [2 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [2 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} =C2=A0 =C2=A0 was: Given the following LogicalPlan: {code:java} scala> val plan =3D spark.sql("SELECT 1 bar FROM (SELECT 1 foo) WHERE foo I= N (SELECT 1 foo)").queryExecution.logical plan: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan =3D 'Project [1 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [1 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} The following transformation should replace all instances of lit(1) with li= t(2): {code:java} scala> plan.transformAllExpressions { case l @ Literal(1, _) =3D> l.copy(va= lue =3D 2) } res0: plan.type =3D 'Project [2 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} Instead, the nested SubqueryExpression plan is not transformed. The expected output is:=C2=A0 {code:java} 'Project [2 AS bar#29] +- 'Filter 'foo IN (list#31 []) =C2=A0=C2=A0 :=C2=A0 +- Project [2 AS foo#30] =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation {code} =C2=A0 =C2=A0 > plan.transformAllExpressions() doesn't transform expressions in nested Su= bqueryExpression plans > -------------------------------------------------------------------------= ---------------------- > > Key: SPARK-25037 > URL: https://issues.apache.org/jira/browse/SPARK-25037 > Project: Spark > Issue Type: Bug > Components: SQL > Affects Versions: 2.3.1 > Reporter: Chris O'Hara > Priority: Minor > > Given the following LogicalPlan: > {code:java} > scala> val plan =3D spark.sql("SELECT 1 bar FROM (SELECT 1 foo) WHERE foo= IN (SELECT 1 foo)").queryExecution.logical > plan: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan =3D > 'Project [1 AS bar#29] > +- 'Filter 'foo IN (list#31 []) > =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] > =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation > =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name > =C2=A0 =C2=A0 =C2=A0 +- Project [1 AS foo#28] > =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation > {code} > the following transformation should replace all instances of lit(1) with = lit(2): > {code:java} > scala> plan.transformAllExpressions { case l @ Literal(1, _) =3D> l.copy(= value =3D 2) } > res0: plan.type =3D > 'Project [2 AS bar#29] > +- 'Filter 'foo IN (list#31 []) > =C2=A0=C2=A0 :=C2=A0 +- Project [1 AS foo#30] > =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation > =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name > =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] > =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation > {code} > Instead, the nested SubqueryExpression plan is not transformed. > The expected output is:=C2=A0 > {code:java} > 'Project [2 AS bar#29] > +- 'Filter 'foo IN (list#31 []) > =C2=A0=C2=A0 :=C2=A0 +- Project [2 AS foo#30] > =C2=A0=C2=A0 : =C2=A0 =C2=A0 +- OneRowRelation > =C2=A0=C2=A0 +- SubqueryAlias __auto_generated_subquery_name > =C2=A0 =C2=A0 =C2=A0 +- Project [2 AS foo#28] > =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 +- OneRowRelation > {code} > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org