From issues-return-197958-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Aug 3 17:56:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EC66E18072F for ; Fri, 3 Aug 2018 17:56:04 +0200 (CEST) Received: (qmail 59589 invoked by uid 500); 3 Aug 2018 15:56:04 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 59541 invoked by uid 99); 3 Aug 2018 15:56:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 15:56:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 89F20CE9C1 for ; Fri, 3 Aug 2018 15:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 827gR_BXFYCf for ; Fri, 3 Aug 2018 15:56:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E08065F3D0 for ; Fri, 3 Aug 2018 15:56:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ADBE0E2640 for ; Fri, 3 Aug 2018 15:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id F068127779 for ; Fri, 3 Aug 2018 15:56:00 +0000 (UTC) Date: Fri, 3 Aug 2018 15:56:00 +0000 (UTC) From: "Thomas Graves (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-24924) Add mapping for built-in Avro data source MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-24924?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 68393#comment-16568393 ]=20 Thomas Graves commented on SPARK-24924: --------------------------------------- | It wouldn't be very different for 2.4.0. It could be different but I gues= s it should be incremental improvement without behaviour changes. I don't buy this agrument, the code has been restructured a lot and you cou= ld have introduced bugs, behavior changes, etc.=C2=A0 If the user has been = using the databrick spark-avro version for other releases and it was workin= g fine and now we magically map it to a different version and they break, t= hey are going to complain and say, I didn't change anything why did this br= eak.=C2=A0 Users could have also made their own=C2=A0modified version of the databrick= s spark-avro package (which=C2=A0we actually have to support primitive type= s) and thus the implementation is not the same and yet you are assuming it = is.=C2=A0 Just a note the fact we use different version isn't my issue, I'm= happy to make that work, I'm worried about other users who didn't happen t= o see this jira.=C2=A0 =C2=A0I also realize these are 3rd party packages bu= t=C2=A0I think we are making the assumption here based on this being a data= bricks package, which in my opinion we shouldn't.=C2=A0 =C2=A0What if this = was companyX package which we didn't know about, what would/should be the e= xpected behavior?=C2=A0 How many users complained about the csv thing?=C2=A0 Could we just improve = the error message to more simply state, "Multiple sources found, perhaps yo= u are including an external package that also supports avro. Spark started = internally supporting as of release X.Y, please remove the external package= or rewrite to use different function" > Add mapping for built-in Avro data source > ----------------------------------------- > > Key: SPARK-24924 > URL: https://issues.apache.org/jira/browse/SPARK-24924 > Project: Spark > Issue Type: Sub-task > Components: SQL > Affects Versions: 2.4.0 > Reporter: Dongjoon Hyun > Assignee: Dongjoon Hyun > Priority: Minor > Fix For: 2.4.0 > > > This issue aims to the followings. > # Like `com.databricks.spark.csv` mapping, we had better map `com.databr= icks.spark.avro` to built-in Avro data source. > # Remove incorrect error message, `Please find an Avro package at ...`. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org