From issues-return-196119-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Jul 13 14:58:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A0C8C180789 for ; Fri, 13 Jul 2018 14:58:03 +0200 (CEST) Received: (qmail 80326 invoked by uid 500); 13 Jul 2018 12:58:02 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 80091 invoked by uid 99); 13 Jul 2018 12:58:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 12:58:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3D4E7C005C for ; Fri, 13 Jul 2018 12:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.251 X-Spam-Level: X-Spam-Status: No, score=-109.251 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lfnJ7JPv6yOX for ; Fri, 13 Jul 2018 12:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0F18F5F3BA for ; Fri, 13 Jul 2018 12:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7DF65E0CD2 for ; Fri, 13 Jul 2018 12:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31C0A23F9A for ; Fri, 13 Jul 2018 12:58:00 +0000 (UTC) Date: Fri, 13 Jul 2018 12:58:00 +0000 (UTC) From: "Takeshi Yamamuro (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SPARK-24498) Add JDK compiler for runtime codegen MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-24498?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 43025#comment-16543025 ]=20 Takeshi Yamamuro edited comment on SPARK-24498 at 7/13/18 12:57 PM: -------------------------------------------------------------------- I found some weird gen'd code that jdk java compilers can't compile, e.g., - gen'd code includes checked exceptions that are not caught inside [https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-= 8f85177fc023b09d1b6561e4c398275eR21] - cast errors [https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-= 258b71121d8d168e4d53cb5b6dc53ffeR893] - illegal import formats [https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-= 53c8a01004edfc2aabfe81570af05bb0R191] - illegal final qualifiers [https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-= 9853dcf5ce3d2ac1e94d473197ff5768L2669] - illegal generic arrays [https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-= ead8a43fb83df762b597637f413a40a5R322] ... Whether this ticket resolved or not, I think we'd be better to brush up gen= 'd codes so that both jdk java compilers and janino could compile them. If = no problem, how about filing a separate jira for that and fixing them first= ? cc: [~smilegator] [~viirya] [~mgaido] [~kiszk] =C2=A0[~rednaxelafx] was (Author: maropu): I found some weird gen'd code that jdk java compilers can't compile, e.g., - gen'd code includes checked exceptions that are not caught inside https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-8f= 85177fc023b09d1b6561e4c398275eR21 - cast errors https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-25= 8b71121d8d168e4d53cb5b6dc53ffeR893 - illegal import formats https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-53= c8a01004edfc2aabfe81570af05bb0R191 - illegal final qualifiers https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-98= 53dcf5ce3d2ac1e94d473197ff5768L2669 - illegal generic arrays https://github.com/apache/spark/compare/master...maropu:JdkCompiler#diff-ea= d8a43fb83df762b597637f413a40a5R322 ... Whether this ticket resolved or not, I think we'd be better to brush up gen= 'd codes so that both jdk java compilers and janino could compile them. If = no problem, how about filing a separate jira for that and fixing them first= ? cc: [~smilegator] [~viirya] [~mgaido] [~kiszk] > Add JDK compiler for runtime codegen > ------------------------------------ > > Key: SPARK-24498 > URL: https://issues.apache.org/jira/browse/SPARK-24498 > Project: Spark > Issue Type: New Feature > Components: SQL > Affects Versions: 2.3.0 > Reporter: Xiao Li > Priority: Major > > In some cases, JDK compiler can generate smaller bytecode and take less t= ime in compilation compared to Janino. However, in some cases, Janino is be= tter. We should support both for our runtime codegen. Janino will be still = our default runtime codegen compiler.=20 > See the related JIRAs in DRILL:=20 > - https://issues.apache.org/jira/browse/DRILL-1155 > - https://issues.apache.org/jira/browse/DRILL-4778 > - https://issues.apache.org/jira/browse/DRILL-5696 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org