From issues-return-193397-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Jun 5 14:02:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3C77C180625 for ; Tue, 5 Jun 2018 14:02:06 +0200 (CEST) Received: (qmail 8672 invoked by uid 500); 5 Jun 2018 12:02:05 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 8663 invoked by uid 99); 5 Jun 2018 12:02:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2018 12:02:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CA82CCF1C1 for ; Tue, 5 Jun 2018 12:02:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vkSGugP9jad6 for ; Tue, 5 Jun 2018 12:02:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DEEA15F4A9 for ; Tue, 5 Jun 2018 12:02:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2625E0239 for ; Tue, 5 Jun 2018 12:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C29ED210AD for ; Tue, 5 Jun 2018 12:02:00 +0000 (UTC) Date: Tue, 5 Jun 2018 12:02:00 +0000 (UTC) From: "Marco Gaido (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-24468) DecimalType `adjustPrecisionScale` might fail when scale is negative MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-24468?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 01655#comment-16501655 ]=20 Marco Gaido commented on SPARK-24468: ------------------------------------- Thanks for reporting this. I will submit soon a fix. Thanks. > DecimalType `adjustPrecisionScale` might fail when scale is negative > -------------------------------------------------------------------- > > Key: SPARK-24468 > URL: https://issues.apache.org/jira/browse/SPARK-24468 > Project: Spark > Issue Type: Bug > Components: SQL > Affects Versions: 2.3.0 > Reporter: Yifei Wu > Priority: Minor > > Hi, I am using MySQL JDBC Driver along with Spark to do some sql queries. > When multiplying a LongType=C2=A0with a decimal in scientific notation, s= ay > {code:java} > spark.sql("select some_int * 2.34E10 from t"){code} > , decimal 2.34E10 will be treated as decimal(3,-8), and some_int will be= =C2=A0casted as decimal(20,0). > =C2=A0 > So according to the rules in comments: > {code:java} > /* > * Operation Result Precision Result Scale > * --------------------------------------------------------------------= ---- > * e1 + e2 max(s1, s2) + max(p1-s1, p2-s2) + 1 max(s1, s2) > * e1 - e2 max(s1, s2) + max(p1-s1, p2-s2) + 1 max(s1, s2) > * e1 * e2 p1 + p2 + 1 s1 + s2 > * e1 / e2 p1 - s1 + s2 + max(6, s1 + p2 + 1) max(6, s1 + p2 = + 1) > * e1 % e2 min(p1-s1, p2-s2) + max(s1, s2) max(s1, s2) > * e1 union e2 max(s1, s2) + max(p1-s1, p2-s2) max(s1, s2) > */ > {code} > their multiplication will be decimal(3+20+1,-8+0) and thus fails the asse= rt assumption (scale>=3D0) on DecimalType.scala:166. > =C2=A0 > My current workaround is to set spark.sql.decimalOperations.allowPrecisio= nLoss to false. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org