spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <>
Subject [jira] [Assigned] (SPARK-24321) Extract common code from Divide/Remainder to a base trait
Date Fri, 18 May 2018 21:56:00 GMT


Apache Spark reassigned SPARK-24321:

    Assignee:     (was: Apache Spark)

> Extract common code from Divide/Remainder to a base trait
> ---------------------------------------------------------
>                 Key: SPARK-24321
>                 URL:
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Kris Mok
>            Priority: Minor
> There's a lot of code duplication between {{Divide}} and {{Remainder}} expression types.
They're mostly the codegen template (which is exactly the same, with just cosmetic differences),
the eval function structure, etc.
> It tedious to have to update multiple places in case we make improvements to the codegen
templates in the future. This ticket proposes to refactor the duplicate code into a common
base trait for these two classes.
> Non-goal: There another class, {{Pmod}}, that is also similiar to {{Divide}} and {{Remainder}},
so in theory we can make a deeper refactoring to accommodate this class as well. But the "operation"
part of its codegen template is harder to factor into the base trait, so this ticket only
handles {{Divide}} and {{Remainder}} for now.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message