spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liang-Chi Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-23455) Default Params in ML should be saved separately
Date Wed, 16 May 2018 02:48:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-23455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476753#comment-16476753
] 

Liang-Chi Hsieh commented on SPARK-23455:
-----------------------------------------

According to [~josephkb]'s comment at [https://github.com/apache/spark/pull/20633#issuecomment-383747170,]
R should be ok.

> Default Params in ML should be saved separately
> -----------------------------------------------
>
>                 Key: SPARK-23455
>                 URL: https://issues.apache.org/jira/browse/SPARK-23455
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.4.0
>            Reporter: Liang-Chi Hsieh
>            Assignee: Liang-Chi Hsieh
>            Priority: Major
>             Fix For: 2.4.0
>
>
> We save ML's user-supplied params and default params as one entity in JSON. During loading
the saved models, we set all the loaded params into created ML model instances as user-supplied
params.
> It causes some problems, e.g., if we strictly disallow some params to be set at the same
time, a default param can fail the param check because it is treated as user-supplied param
after loading.
> The loaded default params should not be set as user-supplied params. We should save ML
default params separately in JSON.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message