From issues-return-189551-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Apr 18 12:14:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31D7418077A for ; Wed, 18 Apr 2018 12:14:05 +0200 (CEST) Received: (qmail 44684 invoked by uid 500); 18 Apr 2018 10:14:04 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 44586 invoked by uid 99); 18 Apr 2018 10:14:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 10:14:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C0BA9C04A2 for ; Wed, 18 Apr 2018 10:14:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id w3XeCmZAChEZ for ; Wed, 18 Apr 2018 10:14:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CC5365FBF7 for ; Wed, 18 Apr 2018 10:14:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 955CBE0C8D for ; Wed, 18 Apr 2018 10:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F2A5241CB for ; Wed, 18 Apr 2018 10:14:00 +0000 (UTC) Date: Wed, 18 Apr 2018 10:14:00 +0000 (UTC) From: "Xianjin YE (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-24006) ExecutorAllocationManager.onExecutorAdded is an O(n) operation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-24006?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 42224#comment-16442224 ]=20 Xianjin YE commented on SPARK-24006: ------------------------------------ Haven't launch a large enough job to confirm my assumption.. But roughly I guess 5_000-10_000 executors would show some impact, and 100_= 000 and above executors would cause an actual problem.. > ExecutorAllocationManager.onExecutorAdded is an O(n) operation > -------------------------------------------------------------- > > Key: SPARK-24006 > URL: https://issues.apache.org/jira/browse/SPARK-24006 > Project: Spark > Issue Type: Improvement > Components: Spark Core > Affects Versions: 2.3.0 > Reporter: Xianjin YE > Priority: Major > > The ExecutorAllocationManager.onExecutorAdded is an O(n) operations, I be= lieve it will be a problem when scaling out with large number of Executors = as it effectively makes adding N executors at time complexity O(N^2). > =C2=A0 > I propose to invoke onExecutorIdle guarded by=C2=A0 > {code:java} > if (executorIds.size - executorsPendingToRemove.size >=3D minNumExecutors= +1) { // Since we only need to re-remark idle executors when low bound > executorIds.filter(listener.isExecutorIdle).foreach(onExecutorIdle) > } else { > onExecutorIdle(executorId) > }{code} > cc [~zsxwing] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org