spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenchen Fan (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-23960) Mark HashAggregateExec.bufVars as transient
Date Wed, 11 Apr 2018 13:54:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-23960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wenchen Fan resolved SPARK-23960.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.4.0

Issue resolved by pull request 21039
[https://github.com/apache/spark/pull/21039]

> Mark HashAggregateExec.bufVars as transient
> -------------------------------------------
>
>                 Key: SPARK-23960
>                 URL: https://issues.apache.org/jira/browse/SPARK-23960
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Kris Mok
>            Assignee: Kris Mok
>            Priority: Minor
>             Fix For: 2.4.0
>
>
> {{HashAggregateExec.bufVars}} is only used during codegen for global aggregation. Specifically
it's only used while {{doProduceWithoutKeys()}} is on the stack.
> Currently, if an {{HashAggregateExec}} is ever captured for serialization, the {{bufVars}}
would be needlessly serialized.
> This ticket proposes a minor change to mark the {{bufVars}} field as transient to avoid
serializing it. Also, null out this field at the end of {{doProduceWithoutKeys()}} to reduce
its lifecycle so that the {{Seq[ExprCode]}} being referenced can be GC'd sooner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message