spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-23785) LauncherBackend doesn't check state of connection before setting state
Date Sat, 24 Mar 2018 02:18:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-23785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412361#comment-16412361
] 

Sahil Takiar commented on SPARK-23785:
--------------------------------------

Updated the PR.
{quote} in LauncherBackend.BackendConnection, set "isDisconnected" before calling super.close()
{quote}
Done
{quote} The race you describe also exists; it's not what the exception in the Hive bug shows,
though.
{quote}
I tried to write a test to replicate this issue, but it seems its already handled in {{LauncherConnection}},
if the {{SparkAppHandle}} calls {{disconnect}} the client connection automatically gets closed
because it gets an {{EOFException}}, which triggers {{close()}} - the logic is in {{LauncherConnection#run}}.

So I guess its already handled? I added my test case to the PR, should be useful since it
covers what happens when {{SparkAppHandle#disconnect}} is called.

> LauncherBackend doesn't check state of connection before setting state
> ----------------------------------------------------------------------
>
>                 Key: SPARK-23785
>                 URL: https://issues.apache.org/jira/browse/SPARK-23785
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.3.0
>            Reporter: Sahil Takiar
>            Priority: Major
>
> Found in HIVE-18533 while trying to integration with the {{InProcessLauncher}}. {{LauncherBackend}}
doesn't check the state of its connection to the {{LauncherServer}} before trying to run {{setState}}
- which sends a {{SetState}} message on the connection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message